[tor-bugs] #28636 [Core Tor/Tor]: Address WTF-PAD comments by Nick (2018-11-27 over IRC)

[Tor Bug Tracker & Wiki]

#28636: Address WTF-PAD comments by Nick (2018-11-27 over IRC)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed                          |
Parent ID:  #28632                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 So during one of Nick's code reviews, there was some discussion about
 renaming the circuit machine definitions and state structs to spec and
 state.. But we didn't pick good names for the machine state because it is
 confusing with the states of the machines.

 I like either circuit_machine_mutable_t or circuit_machine_mutable_info_t
 or circuit_machine_runtime_t or circuit_machine_runtime_info_t rather than
 the circuit_machine_state_t we landed on from the review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28636#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online