[tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

[Tor Bug Tracker & Wiki]

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 I still don't see how that will work.  This means that if we see a router
 in a consensus that is _not_ a vote, we will still try to download it,
 which is not what we want.

 To be concrete, I've made an attempt at a fix here:
 https://github.com/torproject/tor/pull/1628

 How does the fixup commit look to you?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:84>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online