[tor-bugs] #31009 [Core Tor/Tor]: Tor lets transports advertise private IP addresses in descriptor

[Tor Bug Tracker & Wiki]

#31009: Tor lets transports advertise private IP addresses in descriptor
-------------------------------------------------+-------------------------
 Reporter:  phw                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-pt, tor-bridge, 029-backport,    |  Actual Points:
  035-backport, 040-backport, 041-backport,      |
  anti-censorship-roadmap-july,                  |
  042-deferred-20190918                          |
Parent ID:                                       |         Points:  0.5
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor28-can
-------------------------------------------------+-------------------------
Changes (by phw):

 * status:  needs_revision => needs_review


Comment:

 I turned Roger's patch into a pull request on GitHub:
 https://github.com/torproject/tor/pull/1622

 The patch worked for me. When using a 192.168.0.0/16 address in
 `ServerTransportListenAddr`, tor rewrote it to my machine's external IP
 address. I tested it by taking a look at my bridge's extrainfo descriptor
 on BridgeDB.

 My branch is based on master and I created a changes file as the documents
 in doc/HACKING/ told me. Let me know if there's anything wrong with the
 patch and I'll be happy to fix it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31009#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online