[tor-bugs] #32021 [Core Tor/Tor]: hs-v3: Handle rendezvous client circuit build expire properly

[Tor Bug Tracker & Wiki]

#32021: hs-v3: Handle rendezvous client circuit build expire properly
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  dgoulet
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.3.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, tor-client, tor-circuit  |  Actual Points:
Parent ID:  #30200                           |         Points:  0.4
 Reviewer:  asn                              |        Sponsor:
                                             |  Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 I don't think going the `hs_circ_rend_should_not_time_out()` is correct.

 The function I added does one and only one thing. The "not time out" needs
 to do way more things especially based its decision on the purpose. We
 would need to untangle `circuit_expire_building()` to create a high level
 "has timed out" function for that...

 I agree the name is not so good but I'm quite certain we can not call it
 "timed out".

 I added the documentation in a fixup commit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32021#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online