[tor-bugs] #32499 [Circumvention/Snowflake]: Add a build step / documentation for code reuse in Cupcake
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Dec 5 21:05:26 UTC 2019
#32499: Add a build step / documentation for code reuse in Cupcake
-------------------------------------+-----------------------------
Reporter: arlolra | Owner: arlolra
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: snowflake-webextension | Actual Points:
Parent ID: | Points:
Reviewer: cohosh | Sponsor:
-------------------------------------+-----------------------------
Changes (by cohosh):
* status: needs_review => merge_ready
Comment:
This looks great, thank you for working on this. I also appreciate the
more detailed instructions and pulling the webextension information into
the README.
When talking about initializing a new snowflake
[https://github.com/keroserene/snowflake/commit/276645cf9bd2713d505da0a5e8fc76d2a5d84c3d
#diff-29bf2e0e7e02238523200d8e1c149d54R125 here], can we also encourage
setting the proxy type field that's introduced in #31157? Here's an
example of how it's set in init-webext.js: https://gitweb.torproject.org
/pluggable-transports/snowflake.git/tree/proxy/init-webext.js#n175
It would be nice if they also let us know that they've worked it into
their tool. We could add a sentence encouraging them to reach out to us.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32499#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list