[tor-bugs] #32667 [Core Tor/Tor]: CID 1456199: Resource leak in test_hs_control_store_permanent_creds()

[Tor Bug Tracker & Wiki]

#32667: CID 1456199:  Resource leak in test_hs_control_store_permanent_creds()
----------------------------+------------------------------------
 Reporter:  asn             |          Owner:  (none)
     Type:  defect          |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  tor-hs hs-auth  |  Actual Points:
Parent ID:  #30381          |         Points:  0.1
 Reviewer:  dgoulet         |        Sponsor:  Sponsor27-must
----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 I don't think this will work? Reason is that if `tt_int_op(ret, OP_EQ,
 0);` fails, your `ClientOnionAuthDir` is not set to the
 `perm_creds_dir`...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32667#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online