[tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,    |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:  #30429                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by acat):

 acat30429+5_tor-browser_android_68esr_53 looks like it addresses the
 review comments (except the obsolete prefs, which were not reviewed yet
 according to sysrqb).

 Replying to [comment:18 sysrqb]:
 > Replying to [comment:14 sysrqb]:
 > > Replying to [comment:11 acat]:
 > > > Some comments on acat30429+5_tor-browser_android_68esr_39:
 >
 > > > 805a0b25be322d44138bae0d3a862070c9348fea
 > > > {{{
 > > >   +        // Avoid throwing an error because Ci.nsIPushService
 isn't implemented
 > > >   +        // All other clearing actions should succeed if we arrive
 here.
 > > >   +        Promise.resolve();
 > > > }}}
 > > >   Promise.resolve(); is not really doing anything I think.
 > >
 > > I don't actually know. I'll try testing this without that line and see
 if it still works.
 > >
 >
 > It seems like you're correct, we don't need this. However, I don't know
 if we should keep this such that the code is more readable/easier to
 understand? Alternatively, I can delete the `resolve()` line and modify
 the comment.
 I'm not sure it's more readable, but that's subjective I guess :) I read
 is as a noop: it's a statement without side-effects and the value is not
 used nor returned.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31010#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online