[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 This problem prevented us from making much progress today in testing the
 ESR68-based updater on Windows. Does anyone else have time to work on this
 bug? Kathy and I are mostly away from keyboard between now and our release
 date :(

 One possible workaround would be to modify the `mywcsprintf ()` function
 to replace all occurrences of %s with %S in the format string before
 calling `_vsnwprintf()`. We should also verify that the same bug exists in
 32bit builds or that any workaround we implement does not break the 32bit
 updater.

 See https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/update/common/updatedefines.h?h=tor-
 browser-68.1.0esr-9.0-1#n44

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online