[tor-bugs] #31563 [- Select a component]: Urlbar search icons disappear after browser restart

[Tor Bug Tracker & Wiki]

#31563: Urlbar search icons disappear after browser restart
-------------------------------------+-------------------------------------
     Reporter:  acat                 |      Owner:  (none)
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  - Select a           |    Version:
  component                          |   Keywords:  ff68-esr,
     Severity:  Normal               |  TorBrowserTeam201908, tbb-9.0-must-
                                     |  alpha
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 Patch for #30845 fixes this issue on a fresh profile, but not on an
 already existing profile which was already restarted at least once. On top
 of that, there is a quite surprising behaviour:

 1. Open Tor Browser ESR68 without patch for #30845.
 2. Restart browser.
 3. Check that search icons have disappeared.
 4. Change pref from #30845 and restart.
 5. Urlbar is unusable, and browser console shows:

 {{{
 1567091784597   addons.xpi-utils        WARN    Synchronous load of XPI
 database due to getAddonsByType([theme]) Stack:
 getAddonsByType at resource://gre/modules/addons/XPIDatabase.jsm:1997:21
 installBuiltinAddon at resource://gre/modules/addons/XPIInstall.jsm:4283:24
 _openNetworkSettings at jar:file:///tor-browser_en-
 US/Browser/browser/omni.ja!/chrome/torlauncher/components/tl-
 process.js:749:11
 _controlTor at jar:file:///tor-browser_en-
 US/Browser/browser/omni.ja!/chrome/torlauncher/components/tl-
 process.js:584:14
 TorStartAndControlTor at jar:file:///tor-browser_en-
 US/Browser/browser/omni.ja!/chrome/torlauncher/components/tl-
 process.js:331:10
 observe at jar:file:///tor-browser_en-
 US/Browser/browser/omni.ja!/chrome/torlauncher/components/tl-
 process.js:133:14
 }}}

 which might be related, but did not investigate yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31563>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online