[tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,       |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908       |
Parent ID:  #30322                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:45 gk]:
 > Replying to [comment:44 tom]:
 > >  - Have you confirmed you don't need the spec thing for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1460801 ?  (If so, I can
 close that bug.)
 >
 > I think it worked for me back then a couple of months ago when I worked
 on the toolchain. I'll double-check with nightly builds once things landed
 but am optimistic.
 >
 > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 >
 > I think we don't need it when building with `mingw-w64-clang`. At least
 the build passes and I'd suspect compile time issues if that were a
 problem.
 >
 > >  - I see some flags in our mozconfig you don't have:
 > >    - https://searchfox.org/mozilla-
 central/rev/325c1a707819602feff736f129cb36055ba6d94f/browser/config/mozconfigs/win32/mingwclang#53-54
 >
 > Yes, I am not sure why we don't need those but the build is not
 breaking, so we could leave that investigation for later.

 From reading a bit more in the respective Mozilla bug I think we don't
 need those lines as we only have one clang available in our build
 environment (the one we intend to get used). Thus, there won't be any
 potential compiler confusion.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28238#comment:50>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online