[tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,       |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908       |
Parent ID:  #30322                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by tom):

 Replying to [comment:47 gk]:
 > Replying to [comment:46 tom]:
 > > > >  - fxc2 requires the winpthread dll to be in its bin directly
 IIRC; but I don't see where you're copying that. (I might have missed it.
 If you're not getting errors on fxc2 it must be working.)
 > > >
 > > > I think we don't need it when building with `mingw-w64-clang`. At
 least the build passes and I'd suspect compile time issues if that were a
 problem.
 > > >
 > >
 > > No, from my recollection it will compile fine but won't run if the dll
 is missing from the directory.  (However if firefox builds, then fxc2
 didn't error and it worked...)
 >
 > Another thought here: how are you compiling `fxc2`? I recall that I
 needed to resort to the .dll when compiling `fxc2` with `mingw-w64-gcc`,
 which was my main motivation to use `mingw-w64-clang` when building `fxc2`
 as well.

 No, you're right - I completely misremembered; I'm sorry. When I cut fxc2
 over to mingw-clang I got rid of needing winpthread (which makes sense now
 that I think more deeply about it.)  https://hg.mozilla.org/mozilla-
 central/rev/918d2aeb31eb7d18603be0c5f6ae9b27c12b6fc2

 Sorry!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28238#comment:48>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online