[tor-bugs] #31529 [Core Tor/Tor]: config refactoring: fix redundant reset logic

[Tor Bug Tracker & Wiki]

#31529: config refactoring: fix redundant reset logic
-------------------------------+-----------------------------------------
     Reporter:  nickm          |      Owner:  nickm
         Type:  defect         |     Status:  assigned
     Priority:  Medium         |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:  network-team-roadmap-august
Actual Points:                 |  Parent ID:  #29211
       Points:  0              |   Reviewer:
      Sponsor:  Sponsor31-can  |
-------------------------------+-----------------------------------------
 We have this block in our code now:
 {{{
     // XXXX This is unreachable, since a CLEAR line always has an
     // XXXX empty value.
     config_reset(mgr, options, mvar, use_defaults); // LCOV_EXCL_LINE
 }}}

 We should fix it by changing it to a nonfatal assertion.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31529>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online