[tor-bugs] #31385 [Circumvention/Snowflake]: Snowflake client fails after bootstrap
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Aug 24 14:28:14 UTC 2019
#31385: Snowflake client fails after bootstrap
-------------------------------------+-----------------------------
Reporter: cypherpunks | Owner: cohosh
Type: defect | Status: merge_ready
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------+-----------------------------
Changes (by arlolra):
* status: needs_review => merge_ready
Comment:
> Can someone review this ASAP and I'll push an update?
Yeah, looks like this was the intention in `2521f4f`.
Couple of notes, L89 in proxy/snowflake.js is redundant,
{{{
if (pair.active) {
...
} else {
return pair.active = false;
}
}}}
Also, since the timeout sets up a race, maybe add a `this.active` check in
`channel.onopen`.
I guess this is another reason to tackle #31310
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31385#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list