[tor-bugs] #30914 [Core Tor/Tor]: Move struct manipulation code out of confparse.c

[Tor Bug Tracker & Wiki]

#30914: Move struct manipulation code out of confparse.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29211        |         Points:  1
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I did an initial skim, and asked for some comment clarifications.

 I don't know how to do a comprehensive review on a 2,300 line diff:
 * Are there any parts you would like me to focus on?
 * Is there any way to make future pull requests smaller?
   * I would rather review 10 small pull requests I can keep in my head,
 than one big one I struggle to understand
 * What automated tools are we using to make sure this code is high-
 quality? Should we also run extra tools on this code?
   * clang scan-build or fuzzers come to mind, but perhaps there are other
 better tools

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30914#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online