[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-must-nightly,                |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 The updater patches are ready for review now. Please examine the following
 commits on our bug30429-pc-03 branch within the brade tor-browser.git repo
 (https://gitweb.torproject.org/user/brade/tor-
 browser.git/log/?h=bug30429-pc-03):
 {{{
 9f9017a63b156e11af23b55fde36223b74d859e4
     Bug 13379: Sign our MAR files.

 9aa2a90005dde6a7ea2bf58b63241d27912a78eb
     Bug 4234: Use the Firefox Update Process for Tor Browser.

 afb98b58e51c64f4a5a8f51ff68cbd4a801dc831
     Bug 19121: reinstate the update.xml hash check

 bff9eb4e1fc5244b53533f4fdbbc43a0ffbd43fd
     Bug 19121: reinstate the update.xml hash check

 88bc9543973ac089fcb9a3c5c9aae2295086e99b
     Bug 13252: Do not store data in the app bundle
 }}}
 Also, that branch includes a couple of fixup commits that will be needed:
 {{{
 89177dd51ae361d5360abae00387a1d75c15a1be
     fixup! TB4: Tor Browser's Firefox preference overrides.

 55b4bcecc587bb03ce32933096b12fbfb5ceb146
     fixup! Bug 16940: After update, load local change notes.
 }}}

 We inserted them into the patch sequence in a logical place (similar to
 where they are in the ESR60-based Tor Browser).

 We did some testing of all of these patches together on macOS and Linux,
 but not on Windows.

 If you compare the ESR60 and ESR68 patches for #4234, you will notice that
 we omitted the `AdjustPathForUpdater()` code inside
 toolkit/xre/nsUpdateDriver.cpp. The #13379 contains the changes that are
 needed (look for `AppendToLibPath()`) and in ESR60 that #13379 patch just
 removes the `AdjustPathForUpdater()` code that is added by the #4234 patch
 (which seems silly since we don't plan to ever use the #4234 patch without
 the #13379 one).

 We confirmed that the #29180 patch is no longer needed.

 Finally, we noticed a few miscellaneous issues while testing in ESR68 and
 we will open new tickets for them. For example, our Linux alpha build
 wants to create a new profile directory named `RANDOM.default-alpha` which
 is not good for Tor Browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online