[tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

[Tor Bug Tracker & Wiki]

#31343: appveyor: labs(time_t) is not allowed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  backports? 041-must tor-ci           |  Actual Points:  .1
  029-backport 035-backport 040-backport         |
  041-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry, teor                      |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Seems like there is at least one more such issue that is not resolved by
 the above branches and appveyor still fails:
 {{{
 ../src/feature/nodelist/routerlist.c:2923:21: error: absolute value
 function 'labs' given an argument of type 'time_t' {aka 'long long int'}
 but has parameter of type 'long int' which may cause truncation of value
 [-Werror=absolute-value]
  2923 |   time_difference = labs(r2->uptime - (r1->uptime + (r2pub -
 r1pub)));
       |                     ^~~~
 depbase=`echo src/feature/nodelist/fmt_routerstatus.o | sed
 's|[^/]*$|.deps/&|;s|\.o$||'`;\
 }}}

 We should probably fix that one too, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31343#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online