[tor-bugs] #30321 [Applications/Tor Browser]: Adapt Linux toolchain for Firefox 68 ESR

[Tor Bug Tracker & Wiki]

#30321: Adapt Linux toolchain for Firefox 68 ESR
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff68-esr,                   |  Actual Points:
  GeorgKoppen201907, TorBrowserTeam201907,       |
  tbb-9.0-must-nightly                           |
Parent ID:  #30320                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:14 boklm]:
 > My branch `linux_esr68_v6` contains the latest version of the patches
 for the Linux changes:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/log/?h=linux_esr68_v6
 >
 > The top commit from this branch is only for testing and should not be
 merged. It should be replaced by a commit updating the firefox version
 (after we pushed an esr68 branch to `tor-browser.git`).

 Thanks. The language pack related commit looks good to me, nice find! I
 cherry-picked that one to `master` as commit
 4a632f8ac10f5d01ac9ef075fc698bd7454ab6cb. I looked over the ESR 68 changes
 again and tweaked the commit slightly, e.g. by passing `--enabled-proxy-
 bypass-protection` to i686 as well. It's now commit
 c26b8196c90e908a83104c639865a2aca6598efe. Please have a look once you are
 back.

 There are a number of XXX's and issues we still should try to address as
 well. For verbosity they are:

 1) We are installing `python` just for `mach`. I guess we should use the
 one we built ourselves instead?
 2) gold and lld break for 32bit and we need to resort to bfd. This needs
 investigation (I bet Mozilla is not affected here)
 3) We don't get 32bit signing related binaries anymore but we need those.
 We need to fix that.
 4) We need to enable the updater again once the rebases patches are
 available
 5) I think we still should build the debug build with GCC enabled to catch
 potential issues Mozilla is not catching anymore after they switched to
 clang.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30321#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online