[tor-bugs] #31359 [Core Tor/Tor]: Split a control_event module out of control, and make it use control safe logging
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Aug 6 23:01:38 UTC 2019
#31359: Split a control_event module out of control, and make it use control safe
logging
-------------------------------+-----------------------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status: assigned
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Keywords: network-team-roadmap-august
Actual Points: | Parent ID: #30901
Points: 2 | Reviewer:
Sponsor: Sponsor31-can |
-------------------------------+-----------------------------------------
Currently, control events can log messages through the standard logging
module, which can send those logs as control events. This means that some
configurations, future code, or errors might cause an infinite loop.
We should split off a control_event or control_log_event module, and make
it use control safe logging. All it's dependencies should also use control
safe or signal safe logging.
I think we need to make this change after catalyst's control refactor, to
avoid merge conflicts.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31359>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list