[tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

[Tor Bug Tracker & Wiki]

#31356: 0.4.0 relays should not list Padding=1
------------------------------+--------------------------
     Reporter:  mikeperry     |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.4.0.5
     Severity:  Normal        |   Keywords:  wtf-pad
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:  Sponsor2      |
------------------------------+--------------------------
 Somehow we accidentally merged the protover for padding support while
 doing the incremental merge thing, and 0.4.0 relays are advertising
 padding that they don't support. This is mostly harmless, because the
 negotiation will not succeed and then clients will stop, but it will
 result in those clients emitting a "Middle node did not accept our padding
 request" protocol warn/info message.

 We should just remove this protover field from 0.4.0.x.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31356>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online