[tor-bugs] #31338 [Core Tor/Tor]: Practracker --list-overbroad produces confusing output when there is an exception
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Aug 5 15:49:04 UTC 2019
#31338: Practracker --list-overbroad produces confusing output when there is an
exception
-------------------------+-------------------------------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core | Version:
Tor/Tor | Keywords: 042-should, practracker, easy,
Severity: Normal | network-team-roadmap-july
Actual Points: | Parent ID: #29746
Points: 0.1 | Reviewer:
Sponsor: |
Sponsor31-can |
-------------------------+-------------------------------------------------
connection_control_process_inbuf() is 115 lines long, but the exceptions
file says it should be 113.
This line is spurious and should not appear in the output:
{{{
problem function-size
/src/feature/control/control.c:connection_control_process_inbuf() 113 -> 0
}}}
Ideally, practracker should log a message that there are no over-broad
exceptions, but there are violations.
Here is the full output:
{{{
$ scripts/maint/practracker/practracker.py --list-overbroad
problem function-size
/src/feature/control/control.c:connection_control_process_inbuf() 115
FAILURE: practracker found 1 new problem(s) in the code: see warnings
above.
Please fix the problems if you can, and update the exceptions file
(./scripts/maint/practracker/./exceptions.txt) if you can't.
See doc/HACKING/HelpfulTools.md for more information on using practracker.
You can disable this message by setting the TOR_DISABLE_PRACTRACKER
environment
variable.
problem function-size
/src/feature/control/control.c:connection_control_process_inbuf() 113 -> 0
Exit 1
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31338>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list