[tor-bugs] #30942 [Core Tor/Tor]: [warn] Unexpected INTRODUCE_ACK on circuit 3944288021.
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Aug 2 09:46:51 UTC 2019
#30942: [warn] Unexpected INTRODUCE_ACK on circuit 3944288021.
---------------------------------+------------------------------------
Reporter: arma | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-padding | Actual Points:
Parent ID: | Points: 0.2
Reviewer: dgoulet | Sponsor:
---------------------------------+------------------------------------
Changes (by asn):
* status: needs_revision => merge_ready
Comment:
Replying to [comment:6 dgoulet]:
> Nice!
>
> One LAST tiny thing: `handle_relay_command()`, maybe reflect that it is
actually handling a relay cell so like `handle_relay_cell_command()`? In
terms of semantic would be good in the code to pin in the name that the
function is handling a cell as in taking a cell.
>
> Agree or not, feel free to put in `merge_ready` after :).
Done and pushed a new PR because there were conflicts with master due to
the recent practracker improvements:
https://github.com/torproject/tor/pull/1197
Moving to merge_ready as requested.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30942#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list