[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201907R, tbb-9.0       |  Actual Points:
  -must-nightly                                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:19 acat]:
 > Not so important, but I was wondering whether it would be ok to do a
 last pass to fix style issues whenever we think we have a branch ready for
 nightly. I can do this, and it cannot take more than 1 day.
 >
 > I think almost all C++ style should be fine according to `./mach clang-
 format`, but I was thinking to also make the JavaScript code we add or
 modify obey mozilla style (ESLint rules). Many of the style issues can be
 fixed automatically. The rules are quite advanced and tuned to Firefox
 codebase, and sometimes they help fixing bugs (deprecated things in XPCOM,
 etc.). I saw this while working on torbutton integration.

 Good idea, let's do it. I am fine not blocking on our nightly releases for
 this but commit a fixup commit which then gets resolved during a later
 rebase (just if we don't get to it in time).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online