[tor-bugs] #25140 [Core Tor/Tor]: Parse only .torrc files in torrc.d directory

[Tor Bug Tracker & Wiki]

#25140: Parse only .torrc files in torrc.d directory
-------------------------------------------------+-------------------------
 Reporter:  iry                                  |          Owner:
                                                 |  Jigsaw52
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Major                                |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  035-removed-20180711                           |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by Jigsaw52):

 I've added an integration test in commit 5659899.

 It tests using wildcards with %include and the controls commands to reload
 torrc, SAVECONF and getinfo config-can-saveconf.

 I also wanted to use the same test to test reloading the configuration
 file with the seccomp sanbox enabled but I discovered that doing so
 crashes tor on Travis CI. The problem is unrelated to this code as I've
 tested and it happens when %including a folder which used the tor_listdir
 function that was refactored but functionally unchanged (it will use the
 same syscalls and the same arguments as before). This issue is likely
 related to #27315.

 I will look into this problem further but it is going to be difficult to
 solve as I am still not able to reproduce the issue on my system.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25140#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online