[tor-bugs] #30091 [Core Tor/Tor]: Unify parsing code for control.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Apr 24 23:37:18 UTC 2019
#30091: Unify parsing code for control.c
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: 3
Parent ID: #29210 | Points: 3
Reviewer: catalyst | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Comment (by catalyst):
Looking at
{{{
3eed319e4f Use new parser logic for SETCONF/RESETCONF code.
}}}
through
{{{
62695a9307 squash! kvline: handle empty alues as well as empty keys
}}}
Overall this looks good! I like how much smaller
`control_setconf_helper()` became.
I wrote a few small comments on the pull request.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30091#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list