[tor-bugs] #30091 [Core Tor/Tor]: Unify parsing code for control.c

[Tor Bug Tracker & Wiki]

#30091: Unify parsing code for control.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  3
Parent ID:  #29210        |         Points:  3
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by catalyst):

 Looking at
 {{{
 bb2062dd76 kvline: handle empty alues as well as empty keys
 }}}
 through
 {{{
 5d3dcd6fc9 Update more controller commands, now that we have kvline
 support
 }}}

 Overall this looks good, and deletes a lot of repetitive code.

 There's a typo in the bb2062dd76 summary.

 See technical debt comment in the pull request for
 `control_cmd_parse_args()`, and maybe a few more minor comments.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30091#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online