[tor-bugs] #30267 [Core Tor/Tor]: Simplify the code logic of launching HS circuits

[Tor Bug Tracker & Wiki]

#30267: Simplify the code logic of launching HS circuits
---------------------------+-----------------------------------------------
     Reporter:  asn        |      Owner:  (none)
         Type:  defect     |     Status:  new
     Priority:  Medium     |  Milestone:  Tor: unspecified
    Component:  Core       |    Version:
  Tor/Tor                  |
     Severity:  Normal     |   Keywords:  tor-hs refactoring tech-debt easy
Actual Points:             |  Parent ID:
       Points:  1          |   Reviewer:
      Sponsor:             |
---------------------------+-----------------------------------------------
 The intro/rendezvous parts of `circuit_get_open_circ_or_launch()` are very
 complicated, and then they call `circuit_get_open_circ_or_launch()` which
 is also extremely complicated.

 A minimal action item for improving the situation here would be to split
 the HS-parts of `connection_ap_handshake_attach_circuit()` which are
 already pretty disentangled into their own function. That's pretty easy to
 do.

 The harder part of this would be to see if we can also split the HS parts
 of `circuit_get_open_circ_or_launch()` in some way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30267>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online