[tor-bugs] #30251 [Core Tor/sbws]: Add the operating system to the bandwidth file headers

[Tor Bug Tracker & Wiki]

#30251: Add the operating system to the bandwidth file headers
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  enhancement    |         Status:  needs_revision
 Priority:  Medium         |      Milestone:  sbws: 1.2.x-final
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #30255         |         Points:  1
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Replying to [comment:6 juga]:
 > Reminder to myself: i've implemented the operating system, ssl_version
 and tor_version in branch https://github.com/juga0/sbws/tree/ticket30196

 Here's my review of operating system:
 * "system" is a confusing name, please use "operating_system"
 * `platform.platform(aliased=True, terse=True)` uses
 `platform.system_alias()` to produce names that are better known than
 `platform.system()`
 * you added tor_version in two places, but system in one place. Please
 refactor EXTRA_ARG_KEYVALUES and BANDWIDTH_HEADER_KEY_VALUES_INIT so the
 headers are consistent.
 * please submit a bandwidth-file-spec patch, so the reviewer knows what
 your code should do
 * does the "chg: v3bwfile: !refactor, obtain headers from state" commit
 belong in a separate pull request? It's quite large.
 * please submit each feature in a separate pull request

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30251#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online