[tor-bugs] #28269 [Core Tor/Tor]: Repeated HSFETCH queries fail with QUERY_NO_HSDIR
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Apr 19 11:35:51 UTC 2019
#28269: Repeated HSFETCH queries fail with QUERY_NO_HSDIR
------------------------------------------+--------------------------------
Reporter: atagar | Owner: neel
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-control tor-spec | Actual Points:
Parent ID: | Points:
Reviewer: asn | Sponsor:
------------------------------------------+--------------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
LGTM! Just a minor nitpick, please turn `is_rate_limited` and
`rate_limited` into bools to make their purpose more clear. In particular,
it's not clear what `rate_limited` is from its name, so turning it into a
bool will be easier to read the code.
After that, we can put this in merge_ready. Thanks!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28269#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list