[tor-bugs] #30180 [Core Tor/Tor]: CID 1444641: REVERSE_INULL in test_hs_cache.c

[Tor Bug Tracker & Wiki]

#30180: CID 1444641: REVERSE_INULL in test_hs_cache.c
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  0             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Just reported today.
 {{{
 ** CID 1444641:  Null pointer dereferences  (REVERSE_INULL)
 /src/test/test_hs_cache.c: 265 in helper_fetch_desc_from_hsdir()
 259                             &received_desc, &body_used,
 HS_DESC_MAX_LEN, 0);
 260         tor_free(headers);
 261       }
 262
 263      done:
 264       tor_free(hsdir_query_str);
 >>>     CID 1444641:  Null pointer dereferences  (REVERSE_INULL)
 >>>     Null-checking "conn" suggests that it may be null, but it has
 already been dereferenced on all paths leading to the check.
 265       if (conn)
 266         connection_free_minimal(TO_CONN(conn));
 267
 268       return received_desc;
 269     }
 270
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30180>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online