[tor-bugs] #30146 [Core Tor/Tor]: Fix coverity failures as of 04-11-2019

[Tor Bug Tracker & Wiki]

#30146: Fix coverity failures as of 04-11-2019
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 We have 44 coverity warnings right now.  They seem like harmless
 stuff/false positives, but that's still far too many.  Since I'm on this
 rotation this week, I'm going to try to solve them all.

 I'll open subtickets as appropriate.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30146>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online