[tor-bugs] #24622 [Applications/Tor Browser]: Torcrazybutton can't decipher website s3.amazonaws.com

[Tor Bug Tracker & Wiki]

#24622: Torcrazybutton can't decipher website s3.amazonaws.com
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,      |  Actual Points:
  tbb-linkability, GeorgKoppen201903,            |
  TorBrowserTeam201904                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:43 acat]:
 > Here is a patch: https://github.com/acatarineu/tor-browser/commit/24622
 >
 > Not sure if we should wait for more feedback on
 https://bugzilla.mozilla.org/show_bug.cgi?id=1542309. Implemented dveditz
 first suggestion, the alternative I see is to try to fix it just on
 torbutton by looking at the special case when firstPartyOrigin is empty,
 and try to get it from somewhere else
 (nsiChannel.loadInfo.loadingPrincipal?)

 I think that approach is good and we should get the fix into Firefox as
 Mozilla's users are affected by this problem as well.

 Regarding your patch: why did you deal with the insufficient domain level
 case in the code block that is concerned with the scheme of the URL? It
 seems it does not fit there. What about having a special block before that
 one like the ip address error one. It could start with
 `if (rv == NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) {` followed by the
 remainder of your patch. Or maybe you use the ip address error block and
 do a `else if (rv == NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) {` treating both
 error cases together. That might even be better.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24622#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online