[tor-bugs] #30033 [Core Tor/Tor]: The pre-push hook should call the pre-commit hook on the final pushed commit (was: The pre-push hook should call the pre-commit hook on every commit)

[Tor Bug Tracker & Wiki]

#30033: The pre-push hook should call the pre-commit hook on the final pushed
commit
--------------------------+----------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  git-scripts   |  Actual Points:
Parent ID:  #29792        |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+----------------------------------
Description changed by teor:

Old description:

> Sometimes when I do a change, then merge it forward, the pre-commit hook
> doesn't pick up style errors. That's because the pre-commit hook uses the
> old version of our maint scripts, but then I merge the changes into a
> version with stricter maint scripts.
>
> Can we call the pre-commit hook on every pushed commit during the pre-
> push hook?

New description:

 Sometimes when I do a change, then merge it forward, the pre-commit hook
 doesn't pick up style errors. That's because the pre-commit hook uses the
 old version of our maint scripts, but then I merge the changes into a
 version with stricter maint scripts.

 Can we call the pre-commit hook on ~~every~~ the final pushed commit
 during the pre-push hook?

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30033#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online