[tor-bugs] #29959 [Core Tor/Tor]: Actually include the bandwidth file digest in the vote

[Tor Bug Tracker & Wiki]

#29959: Actually include the bandwidth file digest in the vote
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  040-must, 040-backport, fast-fix,    |  Actual Points:  0.2
  nickm-merge                                    |
Parent ID:  #29947                               |         Points:  0.2
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  040-must, 040-backport, fast-fix => 040-must, 040-backport,
     fast-fix, nickm-merge
 * status:  needs_revision => merge_ready


Comment:

 My original fix in #29960 added a failure return value to
 digest256_to_base64().
 But Nick recommended we just crash instead, because failure is unlikely,
 and the resulting code is much simpler.

 So https://github.com/torproject/tor/pull/888 can be merged by Nick,
 because we've swapped reviews here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29959#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online