[tor-bugs] #25688 [Obfuscation/Snowflake]: proxy-go is still deadlocking occasionally

[Tor Bug Tracker & Wiki]

#25688: proxy-go is still deadlocking occasionally
--------------------------------------------+------------------------------
 Reporter:  dcf                             |          Owner:  cohosh
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Low                             |      Milestone:
Component:  Obfuscation/Snowflake           |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:                                  |         Points:  3
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by cohosh):

 > That means that a client can cause the proxy to lose tokens by sending
 an offer, and then doing nothing with the answer.
 Just confirmed this is the case, even with the above fix, in the test
 environment by commenting out
 {{{
         //err := c.pc.SetRemoteDescription(answer)
 }}}
 in `client/lib/webrtc.go`. The client repeatedly tries to connect to a
 snowflake and after 10 tries, the proxy deadlocks because the tokens are
 gone.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25688#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online