[tor-bugs] #23790 [Core Tor/Tor]: rend_service_prune_list_impl_() doesn't copy over desc_is_dirty when copying intro points

[Tor Bug Tracker & Wiki]

#23790: rend_service_prune_list_impl_() doesn't copy over desc_is_dirty when
copying intro points
-------------------------------------------------+-------------------------
 Reporter:  jl                                   |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.7
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport, 031-unreached-         |  Actual Points:  0.1
  backport                                       |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor27-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * points:   => 0.1
 * sponsor:   => Sponsor27-can
 * actualpoints:   => 0.1


Comment:

 I reviewed the 0.2.9 pull request:
 https://github.com/torproject/tor/pull/772

 The new copy_service_on_prunning() function is the same as the 0.3.2
 commit, but the call site is different:
 https://gitweb.torproject.org/user/dgoulet/tor.git/commit/?id=9592797cf3291fceb7715164e519e02a744c2a25

 Once we get another review, I can backport this change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23790#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online