[tor-bugs] #26896 [Core Tor/Tor]: Duplicate call to connection_mark_for_close

[Tor Bug Tracker & Wiki]

#26896: Duplicate call to connection_mark_for_close
-------------------------------------+------------------------------------
 Reporter:  toralf                   |          Owner:  nickm
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  regression 034-backport  |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  dgoulet                  |        Sponsor:
-------------------------------------+------------------------------------

Comment (by Ralph):

 Replying to [comment:3 nickm]:

 > Since this isn't a crash bug, I recommend we merge it first in 0.3.5 and
 then consider a backport.

 I wonder about the "not a crash" part. I've seen this bug on my nodes, and
 typically Tor will die shortly after the incident, according to log files.
 Here's the latest example:
 {{{
 Sep 27 04:59:00 foo Tor[3049]: connection_dir_finished_flushing(): Bug:
 Emptied a dirserv buffer, but it's still spooling! (on Tor 0.3.4.8
 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: connection_mark_for_close_internal_(): Bug:
 Duplicate call to connection_mark_for_close at src/or/directory.c:5201
 (first at src/or/main.c:1210) (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: tor_bug_occurred_(): Bug:
 src/or/connection.c:841: connection_mark_for_close_internal_: This line
 should not have been reached. (Future instances of this warning will be
 silenced.) (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug: Line unexpectedly reached at
 connection_mark_for_close_internal_ at src/or/connection.c:841. Stack
 trace: (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(log_backtrace+0x33)
 [0x559ba45aaa23] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /usr/bin/tor(tor_bug_occurred_+0xb9) [0x559ba45c1069] (on Tor 0.3.4.8
 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /usr/bin/tor(connection_dir_finished_flushing+0x9a) [0x559ba45668ea] (on
 Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /usr/bin/tor(connection_handle_read+0xacb) [0x559ba453f99b] (on Tor
 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(+0x4e5ae)
 [0x559ba449b5ae] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /usr/lib64/libevent-2.1.so.6(+0x20a73) [0x7fae3c70fa73] (on Tor 0.3.4.8
 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /usr/lib64/libevent-2.1.so.6(event_base_loop+0x53f) [0x7fae3c71092f] (on
 Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(do_main_loop+0x17a)
 [0x559ba449d1aa] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(tor_run_main+0x1005)
 [0x559ba449f4b5] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(tor_main+0x26)
 [0x559ba4498b46] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(main+0x9)
 [0x559ba44989a9] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:
 /lib64/libc.so.6(__libc_start_main+0xea) [0x7fae3b840f0a] (on Tor 0.3.4.8
 da95b91355248ad8)
 Sep 27 04:59:00 foo Tor[3049]: Bug:     /usr/bin/tor(_start+0x2a)
 [0x559ba44989ea] (on Tor 0.3.4.8 da95b91355248ad8)
 Sep 27 05:04:12 foo Tor[3049]: connection_dir_finished_flushing(): Bug:
 Emptied a dirserv buffer, but it's still spooling! (on Tor 0.3.4.8
 da95b91355248ad8)
 Sep 27 05:04:12 foo Tor[3049]: connection_mark_for_close_internal_(): Bug:
 Duplicate call to connection_mark_for_close at src/or/directory.c:5201
 (first at src/or/main.c:1210) (on Tor 0.3.4.8 da95b91355248ad8)
 }}}
 These are the last log entries, and my monitoring told me that the Tor
 ports went dead after that. Logging in on the machine showed that the Tor
 process had disappeared.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26896#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online