[tor-bugs] #27795 [Core Tor/Tor]: Possible fd leak on 0.3.5.1-alpha

Thu Sep 20 17:41:24 UTC 2018

#27795: Possible fd leak on 0.3.5.1-alpha
-----------------------------------+------------------------------------
 Reporter:  dgoulet                |          Owner:  nickm
     Type:  defect                 |         Status:  needs_review
 Priority:  High                   |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Critical               |     Resolution:
 Keywords:  regression, tor-relay  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------------

Comment (by dgoulet):

 This lgtm except one thing (unrelated to the main issue at hands):

 * `tor_tls_release_socket()` for NSS, seems to have a possible fd leak if
 `PR_GetIdentitiesLayer()` fails that is we `BUG()` and immediately return
 but I think we should close the `sock`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27795#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online