[tor-bugs] #27728 [Core Tor/Tor]: test: Build an HSv3 descriptor with authorized client is apparently broken

[Tor Bug Tracker & Wiki]

#27728: test: Build an HSv3 descriptor with authorized client is apparently broken
--------------------------+------------------------------------
 Reporter:  Hello71       |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by Hello71):

 specifically, steps to reproduce:

 1. install gcc, maybe you need 8.2.1+20180831-1 (I use Arch, fyi),
 probably 8.2.0 or even earlier will break too

 2. configure tor git master with `CFLAGS='-O3 -flto' LDFLAGS=-flto`
 (probably -O2 works too, but I only tried -O3)

 3. `make src/test/test`

 alternatively:

 1. insert:
 {{{
 #ifndef TOR_UNIT_TESTS
 #error bad include
 #endif
 }}}
 in src/lib/crypt_ops/crypto_rand.h.

 2. make `src/test/test`.

 because only the test executable is being built, all object files must
 define crypto_strongest_rand as the same type. this requires that
 src/lib/crypt_ops/crypto_rand.h must always be included with
 TOR_UNIT_TESTS (or without, but we are forcing only tests to be built
 here)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27728#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online