[tor-bugs] #27741 [Core Tor/Tor]: too many arguments in rust protover_compute_vote()

Mon Sep 17 05:48:59 UTC 2018

#27741: too many arguments in rust protover_compute_vote()
------------------------------+--------------------------
     Reporter:  cyberpunks    |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.3.6
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 [https://gitweb.torproject.org/tor.git/commit/?id=569b4e57e23d728969a12751afc6b45f32d0f093
 569b4e57e23d728969a12751afc6b45f32d0f093] added an argument
 `allow_long_proto_names: bool` in order to `maintain compatibility with
 consensus methods older than 29.`

 The C code never added this 3rd argument and only calls it with 2, which
 can't be safe.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27741>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online