[tor-bugs] #27073 [Core Tor/Tor]: conditionvar_timeout intermittently fails on maint-0.3.3

[Tor Bug Tracker & Wiki]

#27073: conditionvar_timeout intermittently fails on maint-0.3.3
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.8
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-test, 029-backport 032-backport  |  Actual Points:
  033-backport 034-backport                      |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:  regression?, tor-test => tor-test, 029-backport 032-backport
     033-backport 034-backport
 * owner:  (none) => nickm
 * status:  new => accepted


Comment:

 Oh, I've found two problems here: first, the  test launches 4 threads, but
 it doesn't make sure they're all done initializing before it starts
 signalling them.  That probably isn't what's going wrong here.

 The problem is that waiting for 200 msec is not enough when the system is
 under heavy load.  Instead, we should watch for the threads exiting, and
 require that they do so in some reasonable amount of time, but put the
 boundary very high on what counts as "reasonable".

 I've got a patch for the test to do this in `bug27073_029`, with PR at
 https://github.com/torproject/tor/pull/331

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27073#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online