[tor-bugs] #27623 [Applications/Tor Browser]: wrong default pref values in Tor Browser 8.0

[Tor Bug Tracker & Wiki]

#27623: wrong default pref values in Tor Browser 8.0
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-8.0-issues,            |  Actual Points:
  tbb-8.0.1-can                                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:4 mcs]:
 > Replying to [comment:3 gk]:
 > > Do we want that for 8.0.1? I am a bit wary to break things while
 switching to `MOZILLA_OFFICIAL`. What we should do at any rate is looking
 at the differences `MOZILLA_OFFICIAL` is causing and check whether the
 current status of Tor Browser 8 (i.e. not setting it) is problematic. If
 not, then we could give it a round of testing in 8.5a2 maybe? If we think
 we are good got 8.0.1, though, I am happy to take it for that point
 release.
 >
 > Whether to take this for 8.0.1 is a difficult decision. Looking at the
 following, I am more concerned about the lack of `MOZILLA_OFFICIAL` than
 what will happen if we enable it:
 > https://dxr.mozilla.org/mozilla-esr60/search?q=MOZILLA_OFFICIAL
 >
 > For example, `browser/base/content/browser-development-helpers.js` is
 loaded, which adds a surprising "restart the browser now" shortcut key of
 Ctrl+Alt+R (Cmd+Alt+R)on macOS).

 Yes, but that should be a safe thing (even if unexpected), right?

 > On the other hand, we have probably made all ESR60-based Tor Browser
 builds so far without it, so there may be some unexpected problems :(
 >
 > Maybe that argues for trying it in 8.5a2.

 If you feel there is nothing that is potentially harmful then I'd take the
 safe approach and ship 8.5a2 with it first.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27623#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online