[tor-bugs] #27191 [Core Tor/Tor]: handling double spaces in protover

[Tor Bug Tracker & Wiki]

#27191: handling double spaces in protover
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.4-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, 029-backport, 032-backport,    |  Actual Points:
  033-backport, 034-backport                     |
Parent ID:                                       |         Points:
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_information => needs_review
 * cc: nickm (removed)
 * reviewer:   => nickm


Comment:

 Replying to [comment:7 cyberpunks]:
 > Visual inspection of the code made them pretty apparent.
 >
 > Also, it's been 3 weeks now. Is this gonna get reviewed before Friday?

 We aim to review code within a week, but we've been busy with the 0.3.4
 release:
 https://lists.torproject.org/pipermail/tor-
 announce/2018-September/000164.html
 And the 0.3.5 code freeze:
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases

 If it helps, you're not the only person waiting for code reviews:
 https://trac.torproject.org/projects/tor/query?status=needs_review&component=Core+Tor%2FTor&col=id&col=summary&col=status&col=type&col=priority&col=milestone&col=component&order=priority

 I'm still waiting on nickm's opinion on spec vs code changes:

 Replying to [comment:4 teor]:
 > We could also update the protover spec to allow any number of spaces and
 tabs (WS), rather than a single space (SP), and update the C and Rust
 implementations to match.
 >
 > That would be more consistent with Tor's directory document meta-format:
 > https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n193
 >
 > I'd like to get nickm's opinion before we move forward.

 I'll try setting him as reviewer on this ticket instead.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27191#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online