[tor-bugs] #27597 [Applications/Tor Browser]: ASan build option in tor-browser-build is broken

[Tor Bug Tracker & Wiki]

#27597: ASan build option in tor-browser-build is broken
-------------------------------------+-------------------------------------
     Reporter:  gk                   |      Owner:  tbb-team
         Type:  defect               |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  tbb-8.0-issues, tbb-
     Severity:  Normal               |  regression, tbb-rbm
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 Trying to do a ASan build for #27531 results in build breakage due to
 `--enable-tests` and `--enable-debug`. In the first case we get
 {{{
 55:51.29 /var/tmp/build/firefox-
 124fa904c4b2/mfbt/tests/TestWrappingOperations.cpp:27:1: error: non-
 constant condition for static assertion
 55:51.29  static_assert(WrapToSigned(uint8_t(128)) == -128,
 55:51.29  ^~~~~~~~~~~~~
 55:51.29 /var/tmp/build/firefox-
 124fa904c4b2/mfbt/tests/TestWrappingOperations.cpp:27:27:   in constexpr
 expansion of 'mozilla::WrapToSigned<unsigned char>(128)'
 55:51.29 /var/tmp/build/firefox-124fa904c4b2/obj-x86_64-pc-linux-
 gnu/dist/include/mozilla/WrappingOperations.h:89:59:   in constexpr
 expansion of
 'mozilla::detail::WrapToSignedHelper<UnsignedType>::compute<unsigned
 char>(((int)aValue))'
 }}}
 and similar errors. Disabling tests results in packaging errors
 {{{
  0:01.00 /usr/bin/make -j4 -s stage-package
  0:01.71 Error: /var/tmp/build/firefox-124fa904c4b2/browser/installer
 /package-manifest.in:201: Missing file(s):
 bin/components/dom_bindings_test.xpt
  0:01.75 Error: /var/tmp/build/firefox-124fa904c4b2/browser/installer
 /package-manifest.in:246: Missing file(s): bin/components/layout_debug.xpt
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27597>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online