[tor-bugs] #27451 [Core Tor/Tor]: Refactor socket closing in tor_tls_free()

[Tor Bug Tracker & Wiki]

#27451: Refactor socket closing in tor_tls_free()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26631                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 My first attempt at addressing this was in
 b5fddbd24144a94580e50886cd07a82968a1b86c, but that caused bug #27500, and
 had to be reverted with 22e24031452d57852e83738bacfff012439f0258.

 I see two possible solutions here:
   * Find some way to make NSS follow OpenSSL's behavior, and let us free
 the connection without closing the fd.
   * Have OpenSSL follow NSS's behavior (which will be easy) -- and adjust
 our connection code to tolerate that behavior.  (This is what I tried to
 do before).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27451#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online