[tor-bugs] #27500 [Core Tor/Tor]: Tor crashes upon ORPort disconnection

[Tor Bug Tracker & Wiki]

#27500: Tor crashes upon ORPort disconnection
------------------------------+--------------------
     Reporter:  atagar        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  High          |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 Hi Nick, as discussed this morning tor had a regression between commits
 fd994f5-b8a2bdb. Tor crashes when Stem attempts to connect with its ORPort
 then disconnect. Here's its stacktrace...

 {{{
 Sep 05 20:36:47.000 [err] tor_assertion_failed_(): Bug:
 src/core/mainloop/connection.c:5109: assert_connection_ok: Assertion
 or_conn->tls failed; aborting. (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug: Assertion or_conn->tls failed in
 assert_connection_ok at src/core/mainloop/connection.c:5109. Stack trace:
 (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(log_backtrace_impl+0x47)
 [0x55fcc4c95447] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(tor_assertion_failed_+0x94)
 [0x55fcc4c90bb4] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(assert_connection_ok+0x575)
 [0x55fcc4c240a5] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:
 tor(connection_mark_for_close_internal_+0x27) [0x55fcc4c246b7] (on Tor
 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(connection_handle_read+0x517)
 [0x55fcc4c28bb7] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(+0x5470e) [0x55fcc4b0470e] (on Tor
 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     /usr/lib/x86_64-linux-
 gnu/libevent-2.0.so.5(event_base_loop+0x819) [0x7fb789e174c9] (on Tor
 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(do_main_loop+0x1fa)
 [0x55fcc4b069aa] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(tor_run_main+0x11d5)
 [0x55fcc4b09065] (on Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(tor_main+0x3a) [0x55fcc4b012fa] (on
 Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(main+0x19) [0x55fcc4b00e79] (on Tor
 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf0) [0x7fb789196830] (on Tor 0.3.5.0
 -alpha-dev b8a2bdbdc8c46776)
 Sep 05 20:36:47.000 [err] Bug:     tor(_start+0x29) [0x55fcc4b00ec9] (on
 Tor 0.3.5.0-alpha-dev b8a2bdbdc8c46776)
 Aborted (core dumped)
 }}}

 Unfortunately since this is with the ORPort rather than the ControlPort I
 can't provide a simple telnet demo. If you need repro steps just let me
 know and I can come up with a demo.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27500>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online