[tor-bugs] #27465 [Core Tor/Tor]: Windows: cast between incompatible function types in address.c

[Tor Bug Tracker & Wiki]

#27465: Windows: cast between incompatible function types in address.c
----------------------------------------------+----------------------------
 Reporter:  teor                              |          Owner:  teor
     Type:  defect                            |         Status:
                                              |  needs_information
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.4.x-final
Component:  Core Tor/Tor                      |        Version:  Tor:
                                              |  0.3.4.1-alpha
 Severity:  Normal                            |     Resolution:
 Keywords:  035-must, 034-must, 034-backport  |  Actual Points:
Parent ID:  #27389                            |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by teor):

 * status:  assigned => needs_information


Comment:

 This has bitten a lot of other projects. They used a void function pointer
 cast to silence the error:
 https://github.com/official-stockfish/Stockfish/issues/1619
 https://github.com/syzygy1/Cfish/issues/63
 http://emacs.1067599.n8.nabble.com/New-warnings-on-emacs-26-branch-with-
 gcc-8-2-0-td462323.html

 In this particular case, we already got rid of the cast in 0.3.5. So we
 could backport that patch instead of adding another cast.
 (GetAdaptersAddresses and GetProcAddress are only supported on Windows XP,
 so our code won't work on earlier versions anyway.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27465#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online