[tor-bugs] #17835 [Core Tor/Tor]: Make ClientPreferIPv6ORPort smarter

[Tor Bug Tracker & Wiki]

#17835: Make ClientPreferIPv6ORPort smarter
-----------------------------+----------------------------------
 Reporter:  teor             |          Owner:  neel
     Type:  defect           |         Status:  assigned
 Priority:  Medium           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-client ipv6  |  Actual Points:
Parent ID:  #17811           |         Points:  medium/large
 Reviewer:                   |        Sponsor:
-----------------------------+----------------------------------

Comment (by neel):

 I am interested in this bug.

 About this line in this bug report's message:

 >Ignoring localhost (tor_addr_is_localhost) and link-local addresses (a
 new tor_addr_is_link_local)

 I know that the Tor codebase has diverged significantly since the time the
 report was posted. But with today's codebase, I know we have this
 function: `tor_addr_is_internal_()` and `tor_addr_is_internal()`.

 Would it be okay for me to create a function like `tor_addr_is_local()`
 which checks if the address given is either (a) localhost or (b) local
 link?

 Also, when we scan the addresses, is it okay for me to skip the proposed
 `tor_addr_is_local()` if `ClientRejectInternalAddresses` is 0 (such as a
 testing network or chutney)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17835#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online