[tor-bugs] #27620 [Core Tor/Tor]: Use trunnel to parse and generate SOCKS wire format in tor-resolve

[Tor Bug Tracker & Wiki]

#27620: Use trunnel to parse and generate SOCKS wire format in tor-resolve
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  trunnel wireformat socks tor-        |  Actual Points:
  resolve security                               |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Code lgtm overall. Only issue I found is that when I test `tor-resolve`
 with SOCKS5, I get the IP in reverse order :)

 {{{
 $ ./src/tools/tor-resolve -4 torproject.org
 95.216.163.36
 $ ./src/tools/tor-resolve -5 torproject.org
 36.163.216.95
 }}}

 So I'm assuming some place there is a ntohl() missing? :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27620#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online