[tor-bugs] #28125 [Applications/Tor Browser]: Don't let Android leak DNS queries

[Tor Bug Tracker & Wiki]

#28125: Don't let Android leak DNS queries
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Immediate                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-proxy-bypass,        |  Actual Points:
  TorBrowserTeam201810R                          |
Parent ID:  #5709                                |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Great, thanks! I think the most noticeable change resulting from this
 patch is that favicons are not downloaded.

 The patch prevents connections for the following functionality:
  - Sending Crash reports (already disabled) - `CrashReporter.java`
  - Search suggestions (SuggestClient.java)
  - Pocket (already broken, needs API key) - `PocketStoriesLoader.java`
  - After installation from Google Play (under certain conditions) -
 `Distribution.java`
  - Downloadable Content (Disabled at compile time) - `dlc/BaseAction.java`
  - Top/Suggested Sites - `ImageLoader.java`
  - (Fav)Icon download per tab - `IconDownloader.java`
  - Region-specific search engine (always default in TBA because missing
 API key) - `SearchEngineManager.java`
  - Download A/B testing framework config (already disabled) -
 `Switchboard.java`

 As a result, the newly broken functionality includes Image downloading for
 Top/Suggested sites and favicon download.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28125#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online