[tor-bugs] #26035 [Metrics/Statistics]: Streamline sample quantile types used in the various modules
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Oct 27 18:35:13 UTC 2018
#26035: Streamline sample quantile types used in the various modules
--------------------------------+-----------------------------
Reporter: karsten | Owner: karsten
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone:
Component: Metrics/Statistics | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: irl | Sponsor: Sponsor13
--------------------------------+-----------------------------
Comment (by karsten):
Replying to [comment:25 karsten]:
> Replying to [comment:24 irl]:
> > I think this is ready to go, [...]
>
> Thanks for the review! Pushed to master, deploying now, step by step.
Leaving this ticket open until everything's deployed.
Everything's deployed now.
> > [...] but, we should create a new ticket for generalising the
computePercentiles function with generics.
>
> I'll create a slightly different ticket before closing this one: we
should share more code between modules, and a generic
`computePercentiles()` would be one piece of code to consider here. I
wouldn't want to merge a patch that starts with this part of the code. I'd
want us to approach this from a top-down perspective where we generalize
similar functionality and use it in all modules to reduce the overall
amount of code and likelihood of bugs.
Still not closing until I get around to doing this.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26035#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list